GitHub Status updates: On
Free and Open Source: On
Build forked pull requests: On
Pass secrets to builds from forked pull requests: Off
Only build pull requests: On
Auto-cancel redundant builds: On
Enable pipelines: On
If I configured forked repo in CircleCI to build, then the pull request status will not update when the fork pull request build got passed. However, if I pushed some changes to the fork pull request, the next build will update its status correctly.
If I stop build in forked repo in CircleCI, only rely on main repo, everything back to normal.
Jason’s behavior is, I think, normal. (that we will only build under the fork if it is followed, and not the parent) The issue with the GitHub Status not getting a link back is a restriction of how that works, but looking for more information.
Justin, was your issue also with a forked repo where the parent was also on CircleCI? (I’ve updated your user status on the forums from new user)
@drazisil - I didn’t change anything about my CircleCI config (including following) between yesterday, when the status wasn’t updated in GitHub, and today when status was reported properly. The only thing I did today was push another commit, and GitHub integration worked as expected.
The only difference on my end is that my push yesterday was a force-push while today’s was a normal push.
This sounds like a separate issue than the OP. I know that force-pushes tend to sometimes cause issues, but I haven’t heard of anything recently. Can I ask you to open a ticket if this happens again with the payload id from the GitHub webhook settings so we can dig through the logs and see what happened?
You can open for this one too, but given you have pushes after this one it may be harder for you to locate.
Arg. It’s been a long day, sorry. I’m following the wrong mental troubleshooting flowchart. The build ran on CircleCI. So I don’t need the hook. What we need to figure out is why the job never got a status back to GitHub. it will have a type of status
I didn’t realize this was public, that makes it easier. It doesn’t look like this first commit ever got a status back from us, not even a pending. Checking our logs, I see we sent a status back:
marking build-name=justingrant/amplify-js/15 for project=justingrant/amplify-js (commit=4972fc1af43b067e3b968fe5841bf49ef34bfac2) (build-status=:success) as vcs-state=:success, vcs-description=Your tests passed on CircleCI!
at 2019-04-10T00:32:57.761Z, I have no idea why GitHub didn’t show it or other prior statuses for that commit. Yes, please let us know if this happens again.
We have noticed the same behavior thus we do face the same issue, that is the Github status is not updated for a new pull request on the parent repo, when the fork repo uses circleci, until one updates the pull request with a new commit.
Is this issue going to be resolved?