Pull request checks on github are stuck in "in progress", because of type: approval step

github
#1

If you have a job in your workflow, with type: approval, it will cause every pull request to receive a yellow “in progress” mark. Is there any way to filter out the approval step, so that pull requests could receive the green checkmark, if the other jobs in the workflow complete successfully?

I have tried fiddling with the protected branches/workflow jobs setting, so that it only includes the relevant jobs, but that did not help, my pull requests are still stuck in pending.

3 Likes
#3

i had a similar issue when i did not set up separate workflows based on the branch that is being built. on the workflow that you have the approval step, i would try using a filters value and have it only run when building a certain branch, such as smoke branch or a QA- branch.

homepage_smoketest:
jobs:
  - build:
      filters:
        branches:
          only:
            - smoke
            - /QA.*/
#4

I have the same issue. My workflows have approval steps that we don’t necessarily want approve every time. My builds never get green. Every time I have to open CircleCI to see if it’s still running tests or just waiting for approval. Is there a way around it?

#5

I am in the same boat. I have a single workflow. Would setting up multiple workflows fix the pull request status? Is there another workaround. This seems like a big flaw.

#6

agree. it would be nice if there was an optional-approval step, so that once all previous checks passed you’d see the green check.

alternatively, it might make sense for “on hold” workflows without failed checks to show a yellow check

#7

This is a problem for me as well. In particular I cannot merge PRs from my phone because the tests never complete.

#8

I think this is a limitation with GitHub Checks, but can I ask you to create a feature request here https://ideas.circleci.com/ ?

This will put it in front of the product team and allow other customers to vote and comment on it.

#9
1 Like
closed #10

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.