I am pretty new to Git and automated deployments, and I am trying to deploy the changes done as part of my CI to Heroku.
High-level idea:
- Send my code to github
- Circle picks it up, and does some minification
- Circle runs some tests
- Circle deploys to Heroku my files (including the changes I have done to them)
Everything works well, except the files I get on heroku seem to be the files on git, not the modified/minified files.
I guess the problem is coming from here in my yml:
deploy:
docker:
- image: buildpack-deps:trusty
steps:
- checkout
- run:
name: Deploy Master to Heroku
command: |
git push https://heroku:$HEROKU_API_KEY@git.heroku.com/$HEROKU_APP_NAME.git master
However, I am not really sure how to change it.
A) Is it bad practice to send to Heroku directly the modified files? Should I first commit them to github in special release folder and then send that to heroku? how?
B) Is it just something missing in my yml?
Thank you for helping out a beginner