Cancelled Builds Being Marked as Succeeded

[mstruve]

Hi!

I recently cancelled a couple of builds and noticed that they were marked as successful in CircleCi. I also noticed they are returning as successful to Github so a cancelled build on a branch makes it look like the branch ran all tests successfully. This is very concerning since we use circle builds to determine if a branch is safe to merge into master and right now cancelled branches would be allowed to be merged.

If a support person can reach out to me I can send you a lot more specifics.

Thanks!

Molly

[roman]

Hi Molly,

I’m seeing the same thing.
Having cancelled the job during rspec command, it correctly shows a “Step was canceled” message in the console output, but the job badge is a green “success” and the workflow continued with the next steps.