koba04
August 20, 2020, 4:31am
1
I’ve created a PR to facebook/react from a forked repository.
facebook:master ← koba04:add-test-for-non-passive-event-handlers
opened 01:54AM - 20 Aug 20 UTC
<!--
Thanks for submitting a pull request!
We appreciate you spending the … time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
This adds a test @trueadm has commented at https://github.com/facebook/react/pull/19654#issuecomment-676610859.
The test ensures that `unstable_createEventHandle` isn't affected by browsers' intervention #19654 mentioned.
## Test Plan
But most of the CI builds are blocked due to the parallelism.
Uh oh! When we created this build, your project was configured to use 20x parallelism but you only had 4 containers. If you haven’t already, please add more containers or lower your parallelism.
https://app.circleci.com/pipelines/github/koba04/react?branch=add-test-for-non-passive-event-handlers
What should I do to run all builds React provides?
koba04
August 20, 2020, 9:27am
2
koba04
August 20, 2020, 10:16am
3
My colleague has taught me that the following was the reason of the issue.
1 Like
system
August 30, 2020, 10:16am
4
This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.