Allowing Forked PRs to access Secrets

Based on previous requests like Pass secrets to fork PRs after approval

Feature request: Make it such that (if we so configure it) secrets can be passed to fork PRs, but only after a GitHub collaborator has approved the PR using the GitHub review system. Thus, anyone using this tooling can have a workflow along the lines of:

  • PR is submitted from external contributor.
  • Unit tests run and pass on CircleCI
  • Someone with commit bit reviews the PR and approves it in GitHub
  • Unit and system tests run and pass on CircleCI
  • Branch is able to be merged

Opening discussion about needs and work-arounds.

I see only 2 real solutions to this…

  1. Somehow run the pr changes on an internal branch, thus getting access to project settings, including secrets. There are manual ways to do this (change default branch to non-master, merge as an approval). Bors.tech is a great automated way to accomplish that a pre-test merges on an internal branch. And you can see an example here,
  2. Expose Restricted Contexts to forked PRs. Since restricted contexts already consider the actor, not the project, this should ensure only approved actors are allowed to run the config with access to secrets. Maintainers could insert manual approval jobs or push to the PR themselves to get builds to pass.

Have others found any interesting approaches? Does #2 seem viable?

1 Like