Gcp-gke orb fails credentials

Ecosystem Orbs
1

I’ve just started with circleci and I used the following orb to get started deploying straight into our existing GKE cluster:
https://circleci.com/orbs/registry/orb/circleci/gcp-gke

I’ve notice there is a problem with the rollout commands in that the get-credentials command is confused by passing the deployment when it should be the GKE cluster name. This name is not available in the parameters.

For example the source here:

    steps:
      - run: |
          gcloud container clusters get-credentials <<parameters.deployment>>
          kubectl set image deployment <<parameters.deployment>> <<parameters.container>>=<<parameters.image>>

I’ve modified to work for us using the following:

  rollout-image:
    description: "Update a deployment's Docker image."
    parameters:
      deployment:
        description: "The Kubernetes deployment name."
        type: string
      container:
        description: "The container within the deployment pod"
        type: "string"
      cluster:
        description: "The GKE cluster name"
        type: string
      image:
        description: A name for your docker image
        type: string
    steps:
      - run: |
          gcloud container clusters get-credentials <<parameters.cluster>>
          kubectl set image deployment <<parameters.deployment>> <<parameters.container>>=<<parameters.image>>

Is this the right place to raise this as a bug? I can’t find a github repo for this orb specifically.

Also where can we raise feature requests for orbs or to enhance existing orbs?

1 Like
3

Hi there @hawksight, apologies for the delay. You can find the GitHub repository here:

Please file an issue so we can investigate. Feel free to file feature requests against that repository, as well—and thanks!

4

Thanks rose, only just around to looking back at this and looks like someone else already raised the issue here, and it was fixed in the same manner as I had done here.

Thanks for opening up the repo though, very helpful.